Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isActive computation #1682

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Fix isActive computation #1682

merged 2 commits into from
Apr 23, 2020

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Apr 22, 2020 •
edited
Loading

Resolves #1681

Improves the calculation of isActive to reflect:

  • whether there are CrossOriginConfig instances in the aggregator, and
  • whether a secondary source has been set up for the CorsSupportHelper.

@tjquinno tjquinno requested a review from spericas April 22, 2020 20:39
@tjquinno tjquinno self-assigned this Apr 22, 2020
@tjquinno tjquinno changed the title Fix isActive computation [skip ci] Fix isActive computation Apr 22, 2020
@tjquinno tjquinno changed the title [skip ci] Fix isActive computation Fix isActive computation Apr 22, 2020
@tjquinno tjquinno merged commit 1e37487 into helidon-io:master Apr 23, 2020
@tjquinno tjquinno deleted the cors-fix-isactive branch April 23, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

Assignees

@tjquinno tjquinno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS MP can incorrectly ignore annotation-provided CORS info
2 participants
@tjquinno @spericas