Update examples #1715
Merged
Update examples #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
barchetta
commented
May 1, 2020
barchetta
commented
- Eliminate use of some deprecated methods
- MP: Use built-in io.helidon.microprofile.cdi.Main when custom Main not needed
- MP: remove Application classes when not needed
- Remove reference to JDK8 from READMEs
- Other fixes
Don't use Application classes when not needed Remove references to JDK8 in readmes And other minor changes
tomas-langer
previously approved these changes
May 2, 2020
...o-world-explicit/src/main/java/io/helidon/microprofile/example/helloworld/explicit/Main.java
Outdated
Show resolved
Hide resolved
...profile/mp1_1-static-content/src/main/java/io/helidon/microprofile/example/staticc/Main.java
Show resolved
Hide resolved
romain-grecourt
approved these changes
May 4, 2020
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
That's a lot of empty lines :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.