Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP Config fixes #1721

Merged
merged 12 commits into from
May 6, 2020
Merged

MP Config fixes #1721

merged 12 commits into from
May 6, 2020

Conversation

tomas-langer
Copy link
Member

MP Configuration is now compliant with the specification (mutability of config).
Please see #1698 for details.

Resolves #1698

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…rt conflict.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Updated TCK support.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

There is a problem with health and converter. Working on it.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Also an issue with native image.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Native image now works (tested all three MP examples).
Added built-in converters as we have in Helidon SE, to make sure our components work seamlessly.

aseovic
aseovic previously approved these changes May 5, 2020
Copy link
Collaborator

@aseovic aseovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow... That was way more work than I expected it to be, but it looks great.

Thanks a bunch, really appreciate it. Hopefully we can get it in on time for M3.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
danielkec previously approved these changes May 5, 2020
@barchetta
Copy link
Member

You probably don't want to commit examples/todo-app/frontend/package-lock.json

@tomas-langer tomas-langer merged commit 7d2f708 into helidon-io:master May 6, 2020
@tomas-langer tomas-langer deleted the 1698-mp-config branch May 6, 2020 09:44
@barchetta barchetta mentioned this pull request Jul 9, 2020
9 tasks
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Jul 29, 2022
Injecting without explicit key will inject all properties, injecting with a key will inject properties where keys have the prefix removed (and only containing keys that are prefixed with the key).

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer added a commit that referenced this pull request Aug 2, 2022
* Map injection behavior restored to original (pre #1721).
Injecting without explicit key will inject all properties, injecting with a key will inject properties where keys have the prefix removed (and only containing keys that are prefixed with the key).

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MP Config - fix mutability for config sources
4 participants