WebServer configuration changes #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…tion code. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
…nd example code. Updated examples to use new MediaSupport API. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
reviewed
May 12, 2020
| webServer = Main.startServer() | ||
| .start() | ||
| .toCompletableFuture() | ||
| .get(); |
There was a problem hiding this comment.
Timeout can be friendlier in case something goes wrong
barchetta
approved these changes
May 13, 2020
ljnelson
approved these changes
May 13, 2020
romain-grecourt
approved these changes
May 13, 2020
tomas-langer
added a commit
to tomas-langer/helidon
that referenced
this pull request
May 15, 2020
…#1766). Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added a commit
that referenced
this pull request
May 15, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #575
Resolves #453
Need to update:
Ready for code review (except for the docs mentioned above)