Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-P Streaming support #1796

Merged
merged 3 commits into from
May 18, 2020

Conversation

tomas-langer
Copy link
Member

Resolves #1790
Resolves #1793

@tomas-langer tomas-langer self-assigned this May 14, 2020
@m0mus m0mus added this to Needs triage in Backlog May 14, 2020
@tomas-langer tomas-langer removed this from Needs triage in Backlog May 14, 2020
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the changes made to:

  • examples/toto-app/frontend-package-lock.json
  • all unrelated copyright changes

Other than that it looks good.

@tomas-langer
Copy link
Member Author

examples/toto-app/frontend-package-lock.json - I am fixing what I broke in webserver configuration changes.
This is the original state of the file from master.

@tomas-langer
Copy link
Member Author

Removed copyright changes and examples/toto-app/frontend-package-lock.json changes.

@tomas-langer
Copy link
Member Author

Split unrelated changes to #1804 and #1805

danielkec
danielkec previously approved these changes May 15, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Changed generic declaration in API to be more open for users.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member Author

Merging these changes as other changes depend on them.

@tomas-langer tomas-langer merged commit cb662ba into helidon-io:master May 18, 2020
@tomas-langer tomas-langer deleted the 1790-jsonp-streaming branch May 18, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing media mapper ends with unexpected results Create a WebServer media stream mapper for JSON-P
4 participants