Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1802 - Allow use of filters and mappers when converting MP to He… #1803

Merged
merged 1 commit into from
May 15, 2020

Conversation

rlubke
Copy link
Contributor

@rlubke rlubke commented May 14, 2020

…lidon config

Fix is simple - remove the lines disabling filters and mappers when creating the new SE configuration.

Added test to verify the mappers would be available in this scenario.
Was uncertain as to the best approach for filters (or if the mapper test is the best way to verify for that matter), so recommendations are welcome if additional testing on this is desired.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit 9be1f1c into helidon-io:master May 15, 2020
@tomas-langer
Copy link
Member

Thank you for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants