Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedEmittingPublisher as replacement for OriginThreadPublisher #1830

Merged
merged 16 commits into from May 22, 2020
Merged

BufferedEmittingPublisher as replacement for OriginThreadPublisher #1830

merged 16 commits into from May 22, 2020

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented May 19, 2020 •
edited

Simplified replacement for OriginThreadPublisher , performance is better and api is cleaner.

Benchmark                            Mode  Cnt   Score   Error  Units
EmitterTest.testEmitterReqMillion   thrpt   20  21.261 ± 0.160  ops/s
EmitterTest.testEmitterReqOneByOne  thrpt   20  11.845 ± 0.357  ops/s
EmitterTest.testEmitterUnbounded    thrpt   20  44.591 ± 0.131  ops/s
EmitterTest.testOTPReqMillion       thrpt   20  14.702 ± 0.124  ops/s
EmitterTest.testOTPReqOneByOne      thrpt   20   7.707 ± 0.088  ops/s
EmitterTest.testOTPUnbounded        thrpt   20  14.902 ± 0.026  ops/s

JMH test

Used in webclient, webserver, Kafka connector and Multipart #1787

@danielkec
BufferedEmittingPublisher as replacement for OriginThreadPublisher
d77b9f5 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Cleanup
bed4825 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Align with OTP use-cases
49c2177 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Switch webclient to new OTP replacement
035083a 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Noop emit for webclient workaround
a298a01 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Javadoc fix
aac0d2c 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Noop emit for webclient workaround
30fcc8e 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Javadoc fix
f5f17a1 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Switch webserver to new OTP replacement
3426091 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
OTP in webserver Jersey test fix
8bf8560 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Performance boost for unbounded use-cases
183fe73 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec changed the title [WIP]: BufferedEmittingPublisher as replacement for OriginThreadPublisher BufferedEmittingPublisher as replacement for OriginThreadPublisher May 20, 2020
@danielkec danielkec self-assigned this May 20, 2020
@danielkec danielkec added the reactive Reactive streams and related components label May 20, 2020
romain-grecourt
romain-grecourt previously approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 overall. Looks good as a first pass.

@romain-grecourt
Copy link
Contributor

I noticed you are not removing the EmittingPublisher from the kafka module, is that intended ?

@romain-grecourt romain-grecourt mentioned this pull request May 21, 2020
Merged
@danielkec
Another performance boost
a1f2f29 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Cleanup and review issues
9eeab8c 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Kafka connector with new emitter
ea9da46 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Copy link
Contributor Author

@romain-grecourt sorry for late response, Kafka connector switched to BEP in the last commit

@danielkec
Release subscriber reference on complete/error
8916de6 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
OnEmit callback
3163b4d 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@romain-grecourt romain-grecourt merged commit 66200b5 into helidon-io:master May 22, 2020
@romain-grecourt romain-grecourt mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

@akarnokd akarnokd Awaiting requested review from akarnokd

Assignees

@danielkec danielkec

Labels
api-change reactive Reactive streams and related components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielkec @romain-grecourt @tomas-langer