Redesign in Kafka tests #1847
Merged
Redesign in Kafka tests #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
danielkec
reviewed
May 21, 2020
| @@ -180,7 +180,7 @@ public void onComplete() { | |||
| .to(new Subscriber<Message<ConsumerRecord<Long, String>>>() { | |||
| @Override | |||
| public void onSubscribe(Subscription subscription) { | |||
| LOGGER.fine(() -> "onSubscribe()"); | |||
| LOGGER.fine(() -> "channel5 onSubscribe()"); | |||
There was a problem hiding this comment.
It is just the name of the class.
|
I have run this 1944 times and there were no issues. Previously, I was able to find an issue after running it 370 times. |
danielkec
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't change functionality, but I did some changes in the tests.
There are less connections/disconnections to Kafka. CDI container is running during all the execution of the tests.