Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated maven surefire plugin to helidon-standalone-quickstart-mp #1849

Merged
merged 4 commits into from Sep 11, 2020

Conversation

ksurendra
Copy link
Contributor

Following updates were done to "helidon-standalone-quickstart-mp" example.

  1. Updated helidon version to "2.0.0-M3"
  2. Updated maven-surefire-plugin version from <version.plugin.surefire>2.19.1</version.plugin.surefire> to <version.plugin.surefire>3.0.0-M3</version.plugin.surefire>
  3. Updated maven-failsafe-plugin version from <version.plugin.failsafe>2.19.1</version.plugin.failsafe> to <version.plugin.failsafe>3.0.0-M3</version.plugin.failsafe>
  4. Removed <version.plugin.surefire.provider.junit>1.0.3</version.plugin.surefire.provider.junit>
  5. Removed the below from plugin dependencies of maven-surefire-plugin and maven-failsafe-plugin
 <dependency>
   <groupId>org.junit.platform</groupId>
   <artifactId>junit-platform-surefire-provider</artifactId>
   <version>${version.plugin.surefire.provider.junit}</version>
 </dependency>

Why the update?
The version 3.0.0-M3 of maven-surefire-plugin supports Junit 5 natively and there is no need for junit-platform-surefire-provider. One less dependency for the project.

Reference:

@ksurendra
Copy link
Contributor Author

Re: ci/oca-check
I can see my name listed here https://www.oracle.com/technetwork/community/oca-486395.html

@romain-grecourt
Copy link
Contributor

/oca-checked

@romain-grecourt
Copy link
Contributor

/trigger

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksurendra
Copy link
Contributor Author

@barchetta can you review this?

@barchetta barchetta merged commit ec0a126 into helidon-io:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants