New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated maven surefire plugin to helidon-standalone-quickstart-mp #1849
Merged
barchetta
merged 4 commits into
helidon-io:master
from
ksurendra:update-maven-surefire-plugin
Sep 11, 2020
Merged
Updated maven surefire plugin to helidon-standalone-quickstart-mp #1849
barchetta
merged 4 commits into
helidon-io:master
from
ksurendra:update-maven-surefire-plugin
Sep 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from head-master 3/29/2020
pull from master
tomas-langer
requested changes
May 22, 2020
Re: ci/oca-check |
/oca-checked |
/trigger |
romain-grecourt
approved these changes
Sep 1, 2020
tomas-langer
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@barchetta can you review this? |
barchetta
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following updates were done to "helidon-standalone-quickstart-mp" example.
<version.plugin.surefire>2.19.1</version.plugin.surefire>
to<version.plugin.surefire>3.0.0-M3</version.plugin.surefire>
<version.plugin.failsafe>2.19.1</version.plugin.failsafe>
to<version.plugin.failsafe>3.0.0-M3</version.plugin.failsafe>
<version.plugin.surefire.provider.junit>1.0.3</version.plugin.surefire.provider.junit>
Why the update?
The version 3.0.0-M3 of maven-surefire-plugin supports Junit 5 natively and there is no need for junit-platform-surefire-provider. One less dependency for the project.
Reference:
org.apache.maven.plugin.surefire.log.api.ConsoleLogger
junit-team/junit5#1367 (comment)