Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC client API improvements (2.0) #1851

Merged
merged 10 commits into from May 29, 2020
Merged

Conversation

aseovic
Copy link
Collaborator

@aseovic aseovic commented May 22, 2020

This PR has two related things

  1. The same set of client API improvements that make it easier to use as in gRPC client API improvements (1.x) #1850
  2. Renamed @RpcService, @RpcMethod, and @GrpcServiceProxy annotations to @Grpc, @GrpcMethod and @GrpcProxy, to make them consistent with other annotations and/or less verbose.

Current annotations just don't look right when combined:

       @RpcService(name = "FooService")
       @GrpcChannel(name = "foo")
       public interface FooServiceClient {
           ...
       };

This PR changes the above to:

       @Grpc(name = "FooService")
       @GrpcChannel(name = "foo")
       public interface FooServiceClient {
           ...
       };

which reads better and makes a lot more sense long term.

The new name also better describes what the thing is -- it is a gRPC service, not a generic RPC service.

This is a breaking change from 1.x, but considering that gRPC is experimental in 1.x and that 2.0 is a major release, this seems like the right time to make this change.

@tomas-langer tomas-langer added 2.x Issues for 2.x version branch api-change grpc labels May 22, 2020
@tomas-langer tomas-langer added this to the 2.0.0 milestone May 22, 2020
spericas
spericas previously approved these changes May 27, 2020
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit ec11b88 into helidon-io:master May 29, 2020
@tomas-langer
Copy link
Member

Merged changelog.md manually.

@aseovic aseovic deleted the grpc branch June 8, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch api-change grpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants