Service loader added to MediaContext #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verdent
changed the title
tomas-langer
requested changes
May 25, 2020
media/common/src/main/java/io/helidon/media/common/MediaContext.java
Outdated
Show resolved
Hide resolved
media/common/src/main/java/io/helidon/media/common/MediaContext.java
Outdated
Show resolved
Hide resolved
tomas-langer
previously approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM - please follow up with @romain-grecourt to verify the iterator works as it should
romain-grecourt
previously approved these changes
May 26, 2020
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
dismissed stale reviews from romain-grecourt and tomas-langer
via
77487b4
Verdent
force-pushed
the
media-support-service-loader-2
branch
from
94ec41b
to
77487b4
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
tomas-langer
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.