Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of client service APIs between Db and Web Clients. #1863

Merged
merged 3 commits into from May 27, 2020

Conversation

tomas-langer
Copy link
Member

Signed-off-by: Tomas Langer tomas.langer@oracle.com

This is the new aligned approach (metrics and tracing):

        dbClient = DbClient.builder()
                .config(config.get("dbclient"))
                .addService(DbClientMetrics.counter().nameFormat("db.counter.%1$s.%2$s"))
                .addService(DbClientTracing.create())
                .build();

        webClient = WebClient.builder()
                .baseUri("http://localhost:8080/greet")
                .config(config.get("webclient"))
                .addMediaSupport(JsonpSupport.create())
                .addService(WebClientMetrics.counter().nameFormat("counter.%1$s.%2$s.%3$d"))
                .addService(WebClientTracing.create())
                .build();

Resolves #1776

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added 2.x Issues for 2.x version branch DB client Helidon DB Client webclient labels May 25, 2020
@tomas-langer tomas-langer self-assigned this May 25, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit c494634 into helidon-io:master May 27, 2020
@tomas-langer tomas-langer deleted the 1776-align-db-web-api branch May 27, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch DB client Helidon DB Client webclient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align naming DbClient and WebClient
3 participants