Remove MP Metrics 1.0-to-2.0 bridge component and related classes #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjquinno
requested review from
rlubke,
thegridman,
romain-grecourt,
spericas and
tomas-langer
tomas-langer
approved these changes
May 27, 2020
thegridman
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1301
These changes remove the temporary common interface that eased the transition from MicroProfile Metrics 1.x to 2.x.
This PR includes three basic categories of changes:
helidon-common-metricsartifact and its bridge-related classes.metrics/metricscomponent.a. gRPC metrics
b. MP metrics
c. MP fault tolerance
I'm aware that @aseovic has changes to gRPC in #1851. Currently the only file in both that PR and this one is the change log.