Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing performance optimization. #1916

Merged
merged 4 commits into from Jun 2, 2020

Conversation

tomas-langer
Copy link
Member

Signed-off-by: Tomas Langer tomas.langer@oracle.com

Resolves #1915

Tracing now skips creation of spans when the tracer is a Noop.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Jun 1, 2020
Also fixed naming of test methods.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
spericas
spericas previously approved these changes Jun 2, 2020
danielkec
danielkec previously approved these changes Jun 2, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Copy link
Contributor

@batsatt batsatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta added this to the 2.0.0-RC1 milestone Jun 2, 2020
@tomas-langer tomas-langer merged commit b31d0c2 into helidon-io:master Jun 2, 2020
@tomas-langer tomas-langer deleted the 1915-tracing-perf branch June 2, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing causes performance regression even when not enabled
5 participants