Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS Reactive Messaging connector #2282

Merged
merged 15 commits into from
Nov 13, 2020
Merged

JMS Reactive Messaging connector #2282

merged 15 commits into from
Nov 13, 2020

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Aug 21, 2020 •
edited

And Oracle AQ connector based on JMS connector.
Messaging example connecting to OCI autonomous database: https://github.com/danielkec/helidon-messaging-oracle-aq
Signed-off-by: Daniel Kec daniel.kec@oracle.com

Config description in the issue #2098

@danielkec danielkec added the messaging Reactive Messaging label Aug 21, 2020
@danielkec danielkec self-assigned this Aug 21, 2020
@danielkec danielkec linked an issue Aug 21, 2020 that may be closed by this pull request
JMS Messaging Connector #2098
Closed
@paulparkinson paulparkinson self-requested a review August 25, 2020 00:32
@danielkec danielkec force-pushed the 2098-jms-connector branch 7 times, most recently from 9e85205 to efe7dc3 Compare September 7, 2020 20:13
@danielkec danielkec changed the title WIP: JMS Reactive Messaging connector JMS Reactive Messaging connector Sep 16, 2020
tomas-langer
tomas-langer requested changes Sep 17, 2020
View reviewed changes
examples/messaging/jms-websocket-mp/src/main/java/io/helidon/messaging/mp/example/Main.java Outdated Show resolved Hide resolved
...saging/jms-websocket-mp/src/main/java/io/helidon/messaging/mp/example/MsgProcessingBean.java Outdated Show resolved Hide resolved
...saging/jms-websocket-mp/src/main/java/io/helidon/messaging/mp/example/WebSocketEndpoint.java Outdated Show resolved Hide resolved
messaging/aq/src/main/java/io/helidon/messaging/connectors/aq/AqConnector.java Outdated Show resolved Hide resolved
messaging/aq/src/main/java/io/helidon/messaging/connectors/aq/AqMessage.java Outdated Show resolved Hide resolved
messaging/jms/src/main/java/io/helidon/messaging/connectors/jms/SessionMetadata.java Outdated Show resolved Hide resolved
messaging/messaging/src/main/java/io/helidon/messaging/MessagingException.java Outdated Show resolved Hide resolved
messaging/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsMessage.java Outdated Show resolved Hide resolved
messaging/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsMessage.java Outdated Show resolved Hide resolved
@paulparkinson
Copy link
Contributor

paulparkinson commented Sep 19, 2020 •
edited

Awesome work. I think we need a full processor example where incoming and outgoing are both AQ connector channels. I'm still hitting the issues we've discussed offline.

@danielkec danielkec added the dependencies Pull requests that update a dependency file label Oct 9, 2020
paulparkinson
paulparkinson previously approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@paulparkinson paulparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I will do additional testing with it once it's in as well. Great work.

jbescos
jbescos previously approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jbescos jbescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielkec and others added 2 commits October 27, 2020 17:07
@danielkec
JMS Connector
6cb9dd0 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Checkstyle

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Checkstyle 2

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Copyright

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues
6e57efc 
Custom mapper support for outgoing messages

Checkstyle fix

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Copyright fix

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Remove final params

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Review issues

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Fix examples readme

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Fix examples readme 2

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec and others added 8 commits October 27, 2020 17:07
@danielkec
Add connectors to the feature catalog
0821991 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Static module dependency to jakarta
30240a5 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Getter name convention
ee23eb1 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Remove logger from interface
f53007a 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Clean up connector
16fc5c1 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
JmsMessage api refactor
09c98e6 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Derive JMS metadata from message
077f745
@danielkec
Snapshot version alignment
22b138e 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
jbescos
jbescos previously approved these changes Oct 30, 2020
View reviewed changes
mohanishappy
mohanishappy reviewed Nov 6, 2020
View reviewed changes
bom/pom.xml
Comment on lines +843 to +847
<dependency>
<groupId>io.helidon.messaging.aq</groupId>
<artifactId>helidon-messaging-aq</artifactId>
<version>${helidon.version}</version>
</dependency>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I couldn't see this being resolved. May I know if its available for public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, helidon-messaging-aq is part of this PR, it needs to be accepted, merged and then released with new version of Helidon

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the update.

@tomas-langer tomas-langer added this to the 2.1.1 milestone Nov 12, 2020
barchetta
barchetta previously approved these changes Nov 12, 2020
View reviewed changes
@danielkec
Generic return type for getJmsMessage()
665b8be 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Alphabetical version order
fe92d7a 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Align module/directory/package
b661268 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec dismissed stale reviews from barchetta and jbescos via e04627e November 13, 2020 10:50
@danielkec
Property order and javadoc fix
e04627e 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Checkstyle
47921c5 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
tomas-langer approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit f97ae1b into helidon-io:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanishappy mohanishappy mohanishappy left review comments

@jbescos jbescos jbescos approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

@barchetta barchetta barchetta left review comments

@paulparkinson paulparkinson paulparkinson left review comments

@spericas spericas Awaiting requested review from spericas

Assignees

@danielkec danielkec

Labels
dependencies Pull requests that update a dependency file messaging Reactive Messaging
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

JMS Messaging Connector
6 participants
@danielkec @paulparkinson @jbescos @barchetta @mohanishappy @tomas-langer