Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Config.getPropertyNames() instead of retrieving getPropertyNames() from ConfigSources #2322

Merged
merged 1 commit into from Sep 8, 2020
Merged

Use Config.getPropertyNames() instead of retrieving getPropertyNames() from ConfigSources #2322

merged 1 commit into from Sep 8, 2020

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Sep 3, 2020

Signed-off-by: Laird Nelson laird.nelson@oracle.com

@ljnelson
Use Config.getPropertyNames() instead of retrieving getPropertyNames(…
95e18d2 
…) from ConfigSources

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson self-assigned this Sep 3, 2020
@ljnelson ljnelson added the MP label Sep 3, 2020
@ljnelson ljnelson added this to In Progress in Backlog Sep 3, 2020
@ljnelson
Copy link
Member Author

ljnelson commented Sep 3, 2020

See #1693 for some background.

tjquinno
tjquinno approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After quite an enlightening discussion with Laird over slack, LGTM.

@ljnelson ljnelson merged commit 03a018f into helidon-io:master Sep 8, 2020
Backlog automation moved this from In Progress to Closed Sep 8, 2020
@ljnelson ljnelson deleted the 1693 branch September 8, 2020 19:20
@ljnelson ljnelson mentioned this pull request Sep 10, 2020
Merged
@ljnelson ljnelson mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees

@ljnelson ljnelson

Labels
MP
Projects
Backlog
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljnelson @tjquinno