Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataChunkedInputStream deadlock protection removed #2401

Merged
merged 3 commits into from Oct 1, 2020
Merged

DataChunkedInputStream deadlock protection removed #2401

merged 3 commits into from Oct 1, 2020

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Sep 30, 2020

@Verdent
Deadlock protection removed from DataChunkedInputStream
38324ea 
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent
Specific protection tests removed
8291257 
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent self-assigned this Sep 30, 2020
tomas-langer
tomas-langer previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would be good to update javadoc

danielkec
danielkec previously approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@danielkec danielkec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were able to reproduce the deadlock even with reactive stream supplied to callback,
image

It should be highlighted in the doc, that reactive callbacks should be never blocked

@Verdent
javadoc update
ebfd4b7 
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent dismissed stale reviews from danielkec and tomas-langer via ebfd4b7 October 1, 2020 10:40
@Verdent Verdent merged commit 0dc4d4b into helidon-io:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@Verdent Verdent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Verdent @danielkec @tomas-langer