Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP health edits #2443

Merged
merged 3 commits into from Oct 13, 2020
Merged

MP health edits #2443

merged 3 commits into from Oct 13, 2020

Conversation

tjquinno
Copy link
Member

Resolves #2205

@tjquinno tjquinno requested a review from ljamen October 12, 2020 21:12
@tjquinno tjquinno self-assigned this Oct 12, 2020
ljamen
ljamen previously approved these changes Oct 13, 2020
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small typos.

MicroProfile Health support two types of health checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supports

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two types of health checks:

some future point it might become able to do so without requiring a restart.

The following table describes more about these two types of health check, including how an orchestrator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two types of health checks, including....

==== Custom Health Checks
Add your own liveness or readiness checks by adding a Java class for each check.
Each such check must implement the `HealthCheck` interface, and you add either the `@Liveness` or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each custom check

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tjquinno tjquinno merged commit bde9564 into helidon-io:master Oct 13, 2020
@tjquinno tjquinno deleted the health-doc branch October 13, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: MP Health Check changes for 2.0
2 participants