Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config now supports merging of objects and lists #2448

Merged
merged 1 commit into from Oct 15, 2020
Merged

Config now supports merging of objects and lists #2448

merged 1 commit into from Oct 15, 2020

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Oct 14, 2020

Fixes #2427

@Verdent
Config now supports merging of the object with the list
ada6944 
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent self-assigned this Oct 14, 2020
tomas-langer
tomas-langer approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer added this to the 2.1.0 milestone Oct 14, 2020
@Verdent Verdent merged commit 80909a0 into helidon-io:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@Verdent Verdent

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

ConfigSources.create(Config) does not preserve node types
2 participants
@Verdent @tomas-langer