Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging discrepancies #2453

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Messaging discrepancies #2453

merged 3 commits into from
Nov 18, 2020

Conversation

danielkec
Copy link
Contributor

Fixes #2326

@danielkec danielkec self-assigned this Oct 15, 2020
@danielkec danielkec added the messaging Reactive Messaging label Oct 15, 2020
@danielkec danielkec force-pushed the 2326-messaging-discrepancies branch 3 times, most recently from d2f8596 to e04f6e9 Compare October 18, 2020 10:08
@danielkec danielkec changed the title WIP: Messaging discrepancies Messaging discrepancies Oct 18, 2020
@danielkec danielkec added this to the 2.2.0 milestone Nov 13, 2020
@danielkec
Re-enable mp messaging tests
b049c62 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Fix NPE with ack on unknown signature
b6214b5 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Leaking payload fix
bb33633 
  * unwrapped payload leaked to messaging internals for some signatures

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec added the bug Something isn't working label Nov 18, 2020
tomas-langer
tomas-langer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit d8b9458 into helidon-io:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@spericas spericas Awaiting requested review from spericas

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@danielkec danielkec

Labels
bug Something isn't working messaging Reactive Messaging
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Messaging method signatures discrepancies
2 participants
@danielkec @tomas-langer