Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micronaut integration #2467

Merged
merged 18 commits into from
Dec 1, 2020
Merged

Micronaut integration #2467

merged 18 commits into from
Dec 1, 2020

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Oct 19, 2020 •
edited

Resolves #2386

Provides integration with Micronaut as follows:

  • Micronaut Singleton beans can be injected into CDI beans
  • Micronaut interceptors can be used in CDI, as long as proper annotation processor is defined
  • Support for Micronaut Data - tested with JDBC repository (both as an interface and abstract class)
  • Support for Micronaut Bean Validation
  • see example (examples/integrations/micronaut/data)
  • Native image support

Follow ups (TODO):

  • Documentation pages

@tomas-langer tomas-langer added enhancement New feature or request 2.x Issues for 2.x version branch labels Oct 19, 2020
@tomas-langer tomas-langer self-assigned this Oct 19, 2020
@tomas-langer tomas-langer changed the title 2386 Micronaut integration Micronaut integration Oct 20, 2020
@tomas-langer tomas-langer force-pushed the 2386-micronaut-integration branch 2 times, most recently from 1033461 to 3bc55e1 Compare October 20, 2020 09:39
graemerocher
graemerocher reviewed Oct 22, 2020
View reviewed changes
...s/micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/CdiExecutableMethod.java Outdated Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
.../micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautInterceptor.java Outdated Show resolved Hide resolved
...di/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautMethodInvocationContext.java Outdated Show resolved Hide resolved
...di/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautMethodInvocationContext.java Outdated Show resolved Hide resolved
paulparkinson
paulparkinson previously approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@paulparkinson paulparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome :) I've tested it with Oracle ATP database using both hikari and UCP and it works well. So should add micronaut-jdbc-ucp in addition to micronaut-jdbc-hikari we have now, ie...

io.micronaut.sql
micronaut-jdbc-ucp
${version.lib.micronaut.sql}

@tomas-langer
Copy link
Member Author

Rebased and fixed review comments.

@tomas-langer tomas-langer added the dependencies Pull requests that update a dependency file label Nov 9, 2020
@tomas-langer tomas-langer added this to the 2.1.1 milestone Nov 9, 2020
danielkec
danielkec reviewed Nov 19, 2020
View reviewed changes
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
...micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/MicronautCdiExtension.java Outdated Show resolved Hide resolved
...s/micronaut/cdi/src/main/java/io/helidon/integrations/micronaut/cdi/CdiExecutableMethod.java Outdated Show resolved Hide resolved
integrations/micronaut/cdi/README.md Outdated Show resolved Hide resolved
dependencies/pom.xml Outdated Show resolved Hide resolved
@graemerocher
Copy link
Contributor

Just an update that Micronaut 2.2.0 is out which may allow @tomas-langer to cleanup some of the code if I recall

@tomas-langer
squashable
260a855 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
squashable
9d7465c 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
squashable
3d39f33 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Using snapshot for fixed feature
14e2888 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
squashable
3a41570 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
squashable
b9e1e99 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Squashable
43bfcf2 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Micronaut integration, with Micronaut Data support.
5a1e21e 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Checkstyle fixes.
a22ac3e 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Rebase and pom version fix.
5fa440f 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
- module info
8ec2689 
- native image support
- test for example

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Fix javadoc issue.
f643119 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Using the correct Micronaut scope for Dependent.
77594cb 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Support for parameterized types
36f650a 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Review fixes.
a2422b6 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Review comment fixes.
ef91e01 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Upgrade to latest Micronaut release.
f40e241 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
danielkec previously approved these changes Nov 20, 2020
View reviewed changes
@tomas-langer tomas-langer merged commit fa59ea9 into helidon-io:master Dec 1, 2020
@tomas-langer tomas-langer deleted the 2386-micronaut-integration branch December 1, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher left review comments

@danielkec danielkec danielkec approved these changes

@ljnelson ljnelson Awaiting requested review from ljnelson

@spericas spericas Awaiting requested review from spericas

@barchetta barchetta Awaiting requested review from barchetta

@paulparkinson paulparkinson Awaiting requested review from paulparkinson

Assignees

@tomas-langer tomas-langer

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Integration with Micronaut extensions
4 participants
@tomas-langer @graemerocher @danielkec @paulparkinson