Lays the groundwork for permitting other Netty transports while retaining Netty as an implementation-only concern. #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Constraints in play:
|
|
Related issue: #2444; this PR does not directly address this issue but lays the groundwork for a subsequent PR to deal with it. |
ljnelson
added
2.x
tomas-langer
reviewed
Nov 9, 2020
webserver/webserver/src/main/java/io/helidon/webserver/NettyWebServer.java
Outdated
Show resolved
Hide resolved
…ning Netty as an implementation-only concern. Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…and installation of Transport Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…encies/pom.xml to go back to 2020 Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…pyright to be 2021 Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…name is clearer Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
requested review from
romain-grecourt,
paulparkinson,
tjquinno and
spericas
romain-grecourt
approved these changes
Jan 6, 2021
batsatt
reviewed
Jan 6, 2021
Comment on lines
+344
to
+361
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-epoll</artifactId> | ||
| <version>${version.lib.netty}</version> | ||
| <classifier>linux-x86_64</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-epoll</artifactId> | ||
| <version>${version.lib.netty}</version> | ||
| <classifier>linux-aarch64</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-kqueue</artifactId> | ||
| <version>${version.lib.netty}</version> | ||
| <classifier>osx-x86_64</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
Are these actually required by this PR or just in a followup? If the latter, maybe best to leave them out for now.
There was a problem hiding this comment.
These are just the <dependencyManagement> entries (not <dependencies> entries). They do no harm going in now IMHO. A subsequent PR will actually declare dependencies that can use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laird Nelson laird.nelson@oracle.com