Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for a max payload limit on client requests #2491

Merged
merged 6 commits into from
Nov 3, 2020

Conversation

spericas
Copy link
Member

New max-payload-size property in server's configuration to limit size of a client request's payload, using content length or chunked encoding. Default value for property is -1, no limit. Unit for size is bytes.

…mit the payload sizes in client requests, with or without the use of chunked encoding.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas self-assigned this Oct 30, 2020
@spericas spericas added this to High priority in Backlog Oct 30, 2020
@spericas spericas added this to the 2.1.1 milestone Oct 30, 2020
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas changed the title WIP: Support for a max payload limit on client requests Support for a max payload limit on client requests Nov 2, 2020
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. One thing that does stand out is: the header talks about "content" (Content-Length), the error code mentions "payload" and various other things mention "entity". We might want to think about normalizing our nouns in this area.

@spericas
Copy link
Member Author

spericas commented Nov 2, 2020

This looks fine. One thing that does stand out is: the header talks about "content" (Content-Length), the error code mentions "payload" and various other things mention "entity". We might want to think about normalizing our nouns in this area.

It's a good point and I struggled with that too. If you search for HTTP error 413, it will be described as both "payload too large" and "entity too large", so they are partly to blame as well.

@spericas spericas merged commit 7425747 into helidon-io:master Nov 3, 2020
Backlog automation moved this from High priority to Closed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants