Add a shutdown hook to executor service in JerseySupport #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event threads in this executor to attempt reads/writes after Netty's executor is also down. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
jersey-support-shutdown
branch
from
fd4efba
to
c13e776
Compare
|
This fix seems to help but does not completely eliminate the problem of stack traces in log by Netty. There always will be a window perhaps in which those exceptions can be reported. We should decide whether we want to keep this change or not. |
spericas
changed the title
spericas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shutdown hook to executor service in JerseySupport. This should prevent threads in this executor to attempt reads/writes after Netty's executor is also down.
Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com