Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json stream writers #2523

Merged
merged 12 commits into from
Nov 19, 2020
Merged

Json stream writers #2523

merged 12 commits into from
Nov 19, 2020

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Nov 12, 2020

Fixes #1794
Fixes #1795

Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent added the media-support Media type processing in SE label Nov 12, 2020
@Verdent Verdent self-assigned this Nov 12, 2020
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
danielkec
danielkec previously approved these changes Nov 12, 2020
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How about application/x-ndjson ?; the snippet reported in the issue initially used it.

@Verdent
Copy link
Member Author

Verdent commented Nov 16, 2020

I spoke with @dalexandrov and we have decided to add also application/x-ndjson support. I will add the support to this PR once it is done.

@barchetta barchetta added this to the 2.2.0 milestone Nov 16, 2020
Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent merged commit 520bee0 into helidon-io:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
media-support Media type processing in SE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Jackson stream writer Create a JSON-B stream writer
5 participants