Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of logging with Helidon #2533

Merged
merged 4 commits into from
Nov 19, 2020

Conversation

tomas-langer
Copy link
Member

Also added support for native image to log4j, slf4j and JUL modules of the new logging implementation.

Signed-off-by: Tomas Langer tomas.langer@oracle.com

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Nov 18, 2020
@tomas-langer tomas-langer added the dependencies Pull requests that update a dependency file label Nov 18, 2020
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added this to the 2.2.0 milestone Nov 18, 2020
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wondering if we could bump SLF4J to 1.7.30

dependencies/pom.xml Show resolved Hide resolved
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Verdent
Verdent previously approved these changes Nov 18, 2020
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had only one idea there but I will leave that up to you.

examples/logging/jul/README.md Outdated Show resolved Hide resolved
Correct usage of version management for log4j.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit ea9e780 into helidon-io:master Nov 19, 2020
Backlog automation moved this from In Progress to Closed Nov 19, 2020
@tomas-langer tomas-langer deleted the logging-examples branch November 19, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file native-image
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants