Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc for built-in health check thresholds, etc. #2559

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Improve doc for built-in health check thresholds, etc. #2559

merged 4 commits into from
Dec 2, 2020

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Dec 2, 2020

Resolves #2558

Changes JavaDoc for the classes which provide the built-in health checks.

Also adds to the doc site documentation for SE health checks.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno added this to the 2.2.0 milestone Dec 2, 2020
@tjquinno tjquinno self-assigned this Dec 2, 2020
tomas-langer
tomas-langer previously approved these changes Dec 2, 2020
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes from 1.x have been ported to 2.x. Other content looks good.

@tjquinno tjquinno merged commit e483321 into helidon-io:master Dec 2, 2020
@tjquinno tjquinno deleted the health-config-fix branch December 2, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants