Updating JTA and JPA guides #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
barchetta
reviewed
Dec 4, 2020
There was a problem hiding this comment.
Just ran through the JPA guide. Two minor things:
- The log file (line 504) already exists. So you're adding the last 5 lines to an existing file.
- The URL in the curl command on line 544 should be http://localhost:8080/greet/response/Marco
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
barchetta
approved these changes
Dec 4, 2020
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Dec 7, 2020
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laird Nelson laird.nelson@oracle.com