Support for HTTP pipelining #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
previously requested changes
Dec 9, 2020
webserver/webserver/src/main/java/io/helidon/webserver/BareResponseImpl.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Dec 9, 2020
webserver/webserver/src/test/java/io/helidon/webserver/HttpPipelineTest.java
Show resolved
Hide resolved
danielkec
reviewed
Dec 9, 2020
webserver/webserver/src/test/java/io/helidon/webserver/HttpPipelineTest.java
Outdated
Show resolved
Hide resolved
…om, etc. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
ljnelson
reviewed
Dec 9, 2020
webserver/webserver/src/main/java/io/helidon/webserver/BareResponseImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
olotenko
reviewed
Dec 9, 2020
webserver/webserver/src/main/java/io/helidon/webserver/BareResponseImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
romain-grecourt
approved these changes
Dec 10, 2020
danielkec
reviewed
Dec 10, 2020
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Show resolved
Hide resolved
danielkec
approved these changes
Dec 10, 2020
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that responses are ordered correctly when HTTP pipelining is used. If multiple requests are received over the same connection, the corresponding responses need to be ordered according to the spec. It also affects pipelining over HTTP/2 connections. The crux of the fix is to wait for the previous response to complete before writing data for the current one. Thanks to @olotenko.