Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL driver support for JPA/Hibernate in native image #2596

Merged
merged 2 commits into from
Dec 16, 2020
Merged

PostgreSQL driver support for JPA/Hibernate in native image #2596

merged 2 commits into from
Dec 16, 2020

Conversation

Tomas-Kraus
Copy link
Member

To run the tests, build Helidon and then execute:

cd <helidon_root>/tests/integration/jpa
mvn clean install -Dpgsql -Pdocker -pl model,appl -Pnative-image -Dnative-image

Tests run: 16, Failures: 0, Errors: 0, Skipped: 0

@Tomas-Kraus Tomas-Kraus self-assigned this Dec 11, 2020
@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Dec 11, 2020 •
edited

First waiting for native image tests to finish.

edit: 1st run contained test errors to verify whether tests will fail. This worked fine so now scripts were modified to contain proper targets only.
JPA tests contain simple module which runs only with H2 and shall not be used in integration tests with different setup. That's why I added -pl model,appl argument. Maybe I'll remove simple test later. It's the only purpose is to simply develop and debug testing scenarios.

@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Dec 11, 2020 •
edited

@barchetta This is currently blocked by 3rd party approval so adding you as reviewer. Please let us know whether it is moving forward somehow.

@Tomas-Kraus
Copy link
Member Author

@romain-grecourt One of the tests failed during native image build. This is quite strange, because it's not usually happening. I saw it for the first time here. Do you have any idea what's going wrong? Is it resources (memory, disk space) problem?

@Tomas-Kraus
PostgreSQL driver support for JPA/Hibernate in native image
4b7367e 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus
Copy link
Member Author

I had to remove parallel jobs from Jenkinsfile in master because of resource issues. This PR was rebased and squashed to resolve conflicts.

barchetta
barchetta approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving third party dependencies.

@Tomas-Kraus
PostgreSQL JDBC driver version updated to 42.2.18.
c63316e 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus Tomas-Kraus mentioned this pull request Dec 15, 2020
Closed
tomas-langer
tomas-langer approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the changes for mysql are required as part of this PR, it can be merged.

etc/scripts/test-integ-mysql.sh
@@ -52,8 +52,12 @@ mvn ${MAVEN_ARGS} -f ${WS_DIR}/pom.xml \

# Run tests in Java VM application
(cd tests/integration/jpa && \
mvn ${MAVEN_ARGS} clean verify -Dmysql)
mvn ${MAVEN_ARGS} clean verify \
-Dmaven.test.failure.ignore=true -Dmysql \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong - this PR is for psql not for mysql?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was -Dmaven.test.failure.ignore=true missing so I added it into both scripts. They are not being used now and we'll do another review after Romain prepares parallel jobs setup for all those native image integration tests.

etc/scripts/test-integ-pgsql.sh
@@ -0,0 +1,63 @@
#!/bin/bash -ex
#
# Copyright (c) 2018, 2020 Oracle and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright is wrong (as with other new files in this PR) - the year should be just 2020

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's copy-paste. I'll fix it in next PR.

@Tomas-Kraus Tomas-Kraus merged commit 23eb466 into helidon-io:master Dec 16, 2020
@rupesiro rupesiro mentioned this pull request Dec 1, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@Tomas-Kraus Tomas-Kraus

Labels
graal jpa/jta native-image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tomas-Kraus @barchetta @tomas-langer