Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Helidon SE: Update several guides for minor issues #2615

Merged
merged 7 commits into from
Dec 17, 2020

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Dec 15, 2020

Fix #2613
Fix #2612
Fix #2611
Fix #2610

Update documentation following Helidon improvement.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@barchetta barchetta added this to the 2.2.0 milestone Dec 15, 2020
@barchetta
Copy link
Member

Thanks for these contributions! If possible I'd like to get this in for 2.2.0 -- so I've added the milestone.

docs/se/guides/06_tracing.adoc Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Contributor

@batsatt batsatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the jlink related changes.

@tjquinno tjquinno self-requested a review December 17, 2020 17:34
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the doc changes for metrics, health, and tracing work as desired.

@barchetta barchetta merged commit ce9b412 into helidon-io:master Dec 17, 2020
@tvallin tvallin deleted the documentation_se branch April 4, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants