Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation : Helidon DB Client Guide #2673

Merged
merged 6 commits into from
Jul 1, 2022

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Jan 18, 2021

Signed-off-by: tvallin thibault.vallin@oracle.com

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify Routing initialization to simplify it a bit.
I would also like to see an example of sending DbRow as JSON object in HTTP response. But it may be added later.
There is dbclient/jsonp/src/main/java/io/helidon/dbclient/jsonp/JsonProcessingMapper.java to do the job.

docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
@Tomas-Kraus
Copy link
Member

I would like @tomas-langer to check this too.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@romain-grecourt romain-grecourt marked this pull request as draft March 1, 2021 18:27
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin marked this pull request as ready for review October 8, 2021 07:22
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Nov 9, 2021

Issue of this PR : #3621

Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc comments for Helidon DB Client guide.

docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Outdated Show resolved Hide resolved
docs/se/guides/07_db_client.adoc Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin requested a review from ljamen February 15, 2022 12:50
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvallin
Copy link
Member Author

tvallin commented Feb 28, 2022

Hello @tomas-langer,
Is there more work required to merge this PR ?

@barchetta barchetta added this to In Progress in Backlog Mar 10, 2022
@tvallin
Copy link
Member Author

tvallin commented Apr 13, 2022

Hi @romain-grecourt,
A review from you had been requested, do you mind having a quick look at this ?
Thanks.

@romain-grecourt romain-grecourt merged commit 8940e14 into helidon-io:master Jul 1, 2022
Backlog automation moved this from In Progress to Closed Jul 1, 2022
@tvallin tvallin deleted the dbclient_guide branch July 12, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants