Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation SE : OIDC Postman extension #2740

Merged
merged 6 commits into from
Jul 1, 2021

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Feb 5, 2021

This is additional content on OIDC security guide to check how to get token based on different flows with Postman.

Signed-off-by: tvallin thibault.vallin@oracle.com

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin marked this pull request as ready for review February 10, 2021 08:15
@tvallin
Copy link
Member Author

tvallin commented Feb 10, 2021

If these modifications are satisfying, I will update Helidon MP documentation as well.

@tvallin tvallin changed the title Documentation : OIDC Postman extension Documentation SE : OIDC Postman extension Feb 10, 2021
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from technical pov. @ljamen please review from docs pov. Thanks!

Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for doc.

docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@barchetta barchetta self-assigned this Apr 15, 2021
@tomas-langer
Copy link
Member

@tvallin - could you please mark fixed issues as resolved and re-request review?
Thanks

ljamen
ljamen previously approved these changes Apr 20, 2021
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a small suggestion to change the bulleted list to a numbered list.

docs/se/guides/05_security_oidc.adoc Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvallin tvallin requested a review from ljamen June 8, 2021 11:44
@barchetta barchetta merged commit c8fba1c into helidon-io:master Jul 1, 2021
@tvallin tvallin deleted the PostmanExt branch July 8, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants