-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation SE : OIDC Postman extension #2740
Conversation
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
If these modifications are satisfying, I will update Helidon MP documentation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from technical pov. @ljamen please review from docs pov. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates for doc.
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin - could you please mark fixed issues as resolved and re-request review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a small suggestion to change the bulleted list to a numbered list.
Signed-off-by: tvallin <thibault.vallin@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is additional content on OIDC security guide to check how to get token based on different flows with Postman.
Signed-off-by: tvallin thibault.vallin@oracle.com