Improved handling of Jaeger spans/scopes across threads #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms with MP async calls that resulted in memory leaks of ThreadLocalScope objects due to the failed attempt to close a scope from a different thread. New implementation uses a DataPropagationProvider to close a scope on the primary thread and re-open it on the secondary thread --and eventually close it there as well. Minor change to the DataPropagationProvider spi. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
changed the title
…rd compatibility of the SPI. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of Jaeger spans/scopes across threads. Fixes problems with MP async calls that resulted in memory leaks of
ThreadLocalScopeobjects due to the failed attempt to close a scope from a different thread.New implementation uses a
DataPropagationProviderto close a scope on the primary thread and re-open it on the secondary thread --and eventually close it there as well. Minor change to theDataPropagationProviderspi.Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com