New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jackson support #351
Conversation
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should extend the benchmark app to use this and compare it with JSONP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the library to Helidon bom-pom.
media/jackson/common/src/main/java/io/helidon/media/jackson/common/JacksonProcessing.java
Outdated
Show resolved
Hide resolved
media/jackson/server/src/main/java/io/helidon/media/jackson/server/JacksonSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Just fix the checkstyle ;) |
Oh good grief; yep; duh. |
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@tomas-langer Good to go? |
Yes. Sorry, I meant LGTM once you make the build green ;) |
Will repair build again; stand by—it was green, but merging didn't work |
Fixed via #387 |
Signed-off-by: Laird Nelson laird.nelson@oracle.com
This is a reworking of #305.