Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3542 iterable configuration option #3600

Merged

Conversation

dalexandrov
Copy link
Contributor

Fixes issue:
"Config metadata annotation processing throws NPE when @ConfiguredOption annotates method with Iterable argument #3542"

@dalexandrov dalexandrov marked this pull request as ready for review November 1, 2021 11:29
@dalexandrov
Copy link
Contributor Author

/oca-checked

@dalexandrov dalexandrov self-assigned this Nov 2, 2021
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalexandrov dalexandrov requested review from akarnokd and danielkec and removed request for akarnokd November 8, 2021 15:47
Copy link
Collaborator

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be unit tests verifying the supported types are actually working with this Helidon feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants