Fix some remaining problems with disabling metrics, mostly deferring access to RegistryFactory #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still can be changed by later calls to getInstance(MetricsSettings)
tomas-langer
approved these changes
Nov 22, 2021
arjav-desai
pushed a commit
to arjav-desai/helidon
that referenced
this pull request
Nov 27, 2021
…access to RegistryFactory (helidon-io#3663) * Set initial MetricsSettings for creating RegistryFactory from config; still can be changed by later calls to getInstance(MetricsSettings) * Need to support no-op Gauge after all * Defer use of RegistryFactory as long as possible for executor metrics * Reorder some steps in MP metrics service initialization * In MP fault tolerance, defer access to RegistryFactory * In Jaeger metrics defer access to RegistryFactory * In DB client defer access to RegistryFactory * In grpc defer access to RegistryFactory * Add MP/metrics test for disabled metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3653
When metrics are disabled via config, we want to give the code a chance to set the
MetricsSettingsused for theRegistryFactoryaccordingly before theRegistryFactoryis used by other Helidon code.This PR fixes a few remaining issues with that.
The commits are grouped roughly by the affected area to simply reviews.