Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WebSocket from Java HttpClient #3991

Merged

Conversation

tomas-langer
Copy link
Member

Resolves #3988 for Helidon 2.x

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer self-assigned this Mar 22, 2022
@tomas-langer
Copy link
Member Author

I had to recreate this PR, as one commit was not available.

Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer added this to the 2.4.3 milestone Mar 23, 2022
@tomas-langer tomas-langer merged commit 85bb1cb into helidon-io:helidon-2.x Mar 23, 2022
@tomas-langer tomas-langer deleted the 3988-websocket-upgrade branch March 23, 2022 09:07
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Mar 23, 2022
* Upgrade request with content-length 0 now work

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer added a commit that referenced this pull request Mar 23, 2022
* Upgrade WebSocket from Java HttpClient (#3991)
* Upgrade request with content-length 0 now work

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants