Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart cleanup, using @HelidonTest in MP. #4011

Merged

Conversation

tomas-langer
Copy link
Member

Resolves #4007 for 2.x

Signed-off-by: Tomas Langer tomas.langer@oracle.com

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added the 2.x Issues for 2.x version branch label Mar 24, 2022
@tomas-langer tomas-langer added this to the 2.4.3 milestone Mar 24, 2022
@tomas-langer tomas-langer self-assigned this Mar 24, 2022
barchetta
barchetta previously approved these changes Mar 24, 2022
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might want to also check the maven archetypes under archetypes. Some of these changes have already been made there, but maybe not all.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer merged commit d4b7237 into helidon-io:helidon-2.x Mar 25, 2022
@tomas-langer tomas-langer deleted the 4007-quickstarts-2.x branch March 25, 2022 17:27
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Mar 25, 2022
* Quickstart cleanup, using @HelidonTest in MP.
* Archetype update to align with quickstart examples.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer added a commit that referenced this pull request Apr 5, 2022
* Quickstart cleanup, using @HelidonTest in MP. (#4011)

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants