Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Uppgrade grpc-java to 1.45.1 #4146

Merged
merged 1 commit into from
Apr 20, 2022
Merged

2.x: Uppgrade grpc-java to 1.45.1 #4146

merged 1 commit into from
Apr 20, 2022

Conversation

barchetta
Copy link
Member

No description provided.

@barchetta barchetta added 2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file labels Apr 20, 2022
@barchetta barchetta self-assigned this Apr 20, 2022
@barchetta barchetta changed the title Uppgrade grpc-java to 1.45.1 2.x: Uppgrade grpc-java to 1.45.1 Apr 20, 2022
aseovic
aseovic approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@aseovic aseovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Netty version need to be updated as well?

@barchetta
Copy link
Member Author

Does Netty version need to be updated as well?

Already upgraded. We're a bit ahead of what's in grpc-java, but based on some fixes they made it looks like they've been testing with the latest.

@barchetta barchetta merged commit 2bb69e1 into helidon-io:helidon-2.x Apr 20, 2022
@barchetta barchetta deleted the 2.x-grpc-upgrade branch August 17, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseovic aseovic aseovic approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barchetta @aseovic