Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off reference substitution in Hocon parser level for lazy resolution of references #4167

Merged
merged 3 commits into from
May 4, 2022

Conversation

spericas
Copy link
Member

Turn off reference resolution/substitution at parser level and leave reference in tree for later resolution in config module. Unfortunately, to avoid depending on parser impl packages, we need to catch an exception for each parsed reference at this time.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

…reference in tree for later resolution in config module. Unfortunately, to avoid depending on parser impl packages, we need to catch an exception for each parsed reference at this time.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas removed the wip label May 2, 2022
@spericas spericas requested a review from tomas-langer May 2, 2022 16:56
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@spericas spericas merged commit dbacdb9 into helidon-io:helidon-2.x May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Backlog
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants