Routing 3 #4236
Merged
Routing 3 #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkec
force-pushed
the
routing-3
branch
2 times, most recently
from
c0a16eb
to
236dd95
Compare
tomas-langer
requested changes
Jun 20, 2022
There was a problem hiding this comment.
There are a few comments applicable to more than one file (logging.properties commented out sections, module-info.java for testing), please have a look at all of them.
Thank you for the great work, this is almost done and greatly separates concerns within protocols
examples/messaging/jms-websocket-se/src/main/java/io/helidon/examples/messaging/se/Main.java
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
tests/integration/webserver/upgrade/src/test/java/CompressionTest.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/WebServer.java
Outdated
Show resolved
Hide resolved
* Workaround UPM_UNCALLED_PRIVATE_METHOD false positive - spotbugs/spotbugs#947 * Mutable vs. immutable socket config * Cleanup + examples alignment * Compression with upgrade handlers test * Https and wss negotiation with alpn * One codec for enc and decoding Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
requested changes
Jun 24, 2022
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeCodecSupplier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
tomas-langer
previously approved these changes
Jun 27, 2022
webserver/webserver/src/main/java/io/helidon/webserver/UpgradeManager.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/spi/UpgradeCodecProvider.java
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
romain-grecourt
approved these changes
Jun 28, 2022
@romain-grecourt There is one already #4301 |
Merged
ljamen
reviewed
Aug 5, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865