Deal with deprecations in metrics (3.x) #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjquinno
requested review from
ljnelson,
Verdent,
spericas,
tomas-langer and
ljamen
ljamen
reviewed
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4365
This PR is largely a forward-port of the corresponding 2.x changes in #4396 for 3.x (code, doc, and examples).
Note: There are number of methods marked as deprecated in 2.x that we should keep in 3.x (although still marked as deprecated). This way we do not force developers with existing applications to do work to fix applications that would break.
Although it's true that a major release such as 3.0 allows us to make breaking changes, the upcoming rev of the MicroProfile Metrics spec will introduce breaking changes on its own that our developers will have to deal with along with other potential metrics changes in SE.
At a very low cost--the deprecated methods carried forward into 3.0 are typically one-line delegations to their non-deprecated alternatives--we can save our developers successive conversion efforts: now (to 3.0) and again to adopt our next major release.