Add default value constants and use in config doc #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CrossOrigin annotation
|
@arjav-desai @spericas @ljnelson I have added you as reviewers to this for a style question Tomas raised. I added a bunch of constants to the code to support default values. This creates some near-duplication (i.e., bloat) because annotations do not accept "virtually constant" final values that are computed so in some cases there's both a string and a non-string setting. So, the style question is whether the proliferation of constants helps (because related constants are right next to each other so it's more likely someone changing a default will be visually reminded to change both) or hurts (because there's so many pairs of constants which serve the same function). |
…ants (one for actual usage in code, one for the default value in config annos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4359
Added constants for default configured values and used them in assigning initial values and in config doc annotations.