-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Doc PR] - Document migration from 2.x to 3.x #4327 #4507
[New Doc PR] - Document migration from 2.x to 3.x #4327 #4507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we remove a bunch of deprecated APIs in 3.x? Shouldn't those be listed in these guides?
9e1b733
to
99d37fb
Compare
This guide is created for users who have Helidon 2.x application and want to upgrade to 3.x. Now it looks like a copy of Helidon 3.0 announcement article. It's not an announcement. It must contain step by step instructions about how to upgrade a project. It must contain:
|
Apply Daniel suggestion Co-authored-by: Daniel Kec <daniel.kec@oracle.com>
Apply Daniel suggestion Co-authored-by: Daniel Kec <daniel.kec@oracle.com>
Final cleanup!
b3618d4
to
0586369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review comments - open questions re: formatting are for me (we need to come up with a standard and then I can go back and make the edits.)
Resolves "Document migration from 2.x to 3.x" #4327