Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Doc PR] - Document migration from 2.x to 3.x #4327 #4507

Merged

Conversation

dalexandrov
Copy link
Contributor

Resolves "Document migration from 2.x to 3.x" #4327

@dalexandrov dalexandrov added docs 3.x Issues for 3.x version branch labels Jul 11, 2022
@dalexandrov dalexandrov added this to the 3.0.0 milestone Jul 11, 2022
@dalexandrov dalexandrov added this to Backlog in Helidon Doc via automation Jul 11, 2022
@dalexandrov dalexandrov self-assigned this Jul 11, 2022
@m0mus m0mus moved this from Backlog to Assigned in Helidon Doc Jul 11, 2022
@dalexandrov dalexandrov moved this from Assigned to In progress in Helidon Doc Jul 12, 2022
@m0mus m0mus removed this from In progress in Helidon Doc Jul 19, 2022
docs/includes/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/includes/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/includes/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/includes/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/includes/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small suggestions.

docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we remove a bunch of deprecated APIs in 3.x? Shouldn't those be listed in these guides?

docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_3.x.adoc Outdated Show resolved Hide resolved
@dalexandrov dalexandrov force-pushed the 4327_Document_migration_from_2.x_to_3.x branch from 9e1b733 to 99d37fb Compare July 23, 2022 10:57
@m0mus
Copy link
Contributor

m0mus commented Jul 25, 2022

This guide is created for users who have Helidon 2.x application and want to upgrade to 3.x. Now it looks like a copy of Helidon 3.0 announcement article. It's not an announcement. It must contain step by step instructions about how to upgrade a project. It must contain:

  1. JDK version upgrade. This document partically has it, but it only states that Java 17 is supported. You should say that new JDK must be installed and configured on your computer. Possibly make a link to prerequisites.adoc where explained how to set JAVA_HOME.
  2. New versions of MicroProfile (5.0) and Jakarta EE APIs. Your document partially has it. Never say that we support Jakarta EE 9.1. It's wrong. We only support selected subset of Jakarta EE 9.1 APIs. Make sure that verison number is consistent. I see sometimes 9.0, sometimes 9.1. For each specification I miss the version number used in 2.x. You have only the new version number. It would be great to include a short list ofbackwards incompatible chages for each specification. Ideally with some samples.
  3. Deprecations. I miss a full list of deprecated APIs and equivalest new APIs.
  4. Other backwards incompatible changes if any.

@dalexandrov dalexandrov force-pushed the 4327_Document_migration_from_2.x_to_3.x branch from b3618d4 to 0586369 Compare July 25, 2022 17:51
@dalexandrov dalexandrov marked this pull request as ready for review July 25, 2022 17:51
@barchetta barchetta merged commit a9e6c84 into helidon-io:master Jul 25, 2022
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review comments - open questions re: formatting are for me (we need to come up with a standard and then I can go back and make the edits.)

docs/mp/guides/migration_3x.adoc Show resolved Hide resolved
docs/mp/guides/migration_3x.adoc Show resolved Hide resolved
docs/mp/guides/migration_3x.adoc Show resolved Hide resolved
docs/mp/guides/migration_3x.adoc Show resolved Hide resolved
docs/mp/guides/migration_3x.adoc Show resolved Hide resolved
docs/se/guides/migration_3x.adoc Show resolved Hide resolved
docs/se/introduction.adoc Show resolved Hide resolved
docs/se/introduction.adoc Show resolved Hide resolved
docs/se/introduction.adoc Show resolved Hide resolved
docs/includes/oci.adoc Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants