Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New formatting for GraphQL MP document #4514

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Conversation

spericas
Copy link
Member

This PR needs to be rebased after merging PR #4478 as the two share some files. The Configuration section needs to be updated on more time. The rest can be reviewed at this time.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added this to the 3.0.0 milestone Jul 12, 2022
@spericas spericas requested a review from ljamen July 12, 2022 13:40
@spericas spericas added this to Backlog in Helidon Doc via automation Jul 12, 2022
@spericas spericas self-assigned this Jul 12, 2022
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one small change.

docs/mp/graphql.adoc Outdated Show resolved Hide resolved
@spericas spericas added the MP label Jul 12, 2022
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested a review from ljamen July 12, 2022 14:37
@spericas spericas added the 3.x Issues for 3.x version branch label Jul 12, 2022
@spericas spericas moved this from Backlog to In progress in Helidon Doc Jul 12, 2022
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 5cc9bdd into helidon-io:master Jul 13, 2022
@spericas spericas mentioned this pull request Jul 15, 2022
8 tasks
@m0mus m0mus moved this from In progress to Done in Helidon Doc Jul 18, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
* New formatting for GraphQL MP document.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Set correct GraphQL version.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Minor update in Examples.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch graphql MP wip
Projects
Helidon Doc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants