Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry support #4518

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jul 12, 2022

Jaeger OpenTelmetry client
Removed Jaeger client dependencies (including Jaeger metrics)
Added support for OpenTelemetry tracing
MP Tracing now works both with Opentracing and Open Telemetry tracing (using Shim layer)

@tomas-langer tomas-langer added tracing dependencies Pull requests that update a dependency file labels Jul 12, 2022
@tomas-langer tomas-langer added this to the 3.0.0 milestone Jul 12, 2022
@tomas-langer tomas-langer self-assigned this Jul 12, 2022
spericas
spericas previously approved these changes Jul 12, 2022
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barchetta
barchetta previously approved these changes Jul 12, 2022
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency changes approved

@barchetta barchetta mentioned this pull request Jul 12, 2022
9 tasks
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomas-langer tomas-langer merged commit 26f0a4b into helidon-io:master Jul 13, 2022
@tomas-langer tomas-langer deleted the 3717-jaeger-otel branch July 13, 2022 13:15
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
* Jaeger open telemetry client
* Removed Jaeger metrics
* Support for MP Open tracing on top of Open Telemetry

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants