Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE metrics doc reorg #4543

Merged
merged 17 commits into from
Jul 15, 2022
Merged

SE metrics doc reorg #4543

merged 17 commits into from
Jul 15, 2022

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jul 14, 2022 •
edited

See #4306

Updates some files also changed in the earlier MP metrics doc re-org PR.

@tjquinno tjquinno added this to the 3.0.0 milestone Jul 14, 2022
@tjquinno tjquinno requested review from spericas and ljamen July 14, 2022 11:55
@tjquinno tjquinno self-assigned this Jul 14, 2022
@tjquinno tjquinno marked this pull request as draft July 14, 2022 16:35
@m0mus m0mus added the docs label Jul 15, 2022
@tjquinno tjquinno marked this pull request as ready for review July 15, 2022 17:35
@tjquinno tjquinno requested a review from spericas July 15, 2022 17:35
@tjquinno tjquinno merged commit ff25351 into helidon-io:master Jul 15, 2022
@tjquinno tjquinno deleted the doc-metrics-se branch July 15, 2022 21:10
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
@tjquinno @romain-grecourt
SE metrics doc reorg (helidon-io#4543)
0651f13
ljamen
ljamen reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - a few small comments.

docs/includes/metrics/metrics-config.adoc Show resolved Hide resolved
docs/includes/metrics/metrics-shared.adoc Show resolved Hide resolved
docs/includes/metrics/metrics-shared.adoc Show resolved Hide resolved
docs/se/metrics/micrometer.adoc Show resolved Hide resolved
@ljamen ljamen mentioned this pull request Jul 27, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen left review comments

@spericas spericas spericas approved these changes

Assignees

@tjquinno tjquinno

Labels
docs
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tjquinno @spericas @ljamen @m0mus