Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Doc PR] - 4299 Helidon Integrations documentation Neo4J #4598

Merged
merged 6 commits into from
Jul 25, 2022
Merged

[New Doc PR] - 4299 Helidon Integrations documentation Neo4J #4598

merged 6 commits into from
Jul 25, 2022

Conversation

dalexandrov
Copy link
Contributor

@dalexandrov dalexandrov commented Jul 22, 2022 •
edited

Resolves #4299 and #4319 regarding Neo4j

@dalexandrov dalexandrov added this to the 3.0.0 milestone Jul 22, 2022
@dalexandrov dalexandrov self-assigned this Jul 22, 2022
@dalexandrov dalexandrov added this to Backlog in Helidon Doc via automation Jul 22, 2022
@dalexandrov dalexandrov marked this pull request as draft July 22, 2022 12:40
@dalexandrov dalexandrov changed the title [New Doc PR] - 4299Helidon MP Integrations documentation Neo4J [New Doc PR] - 4299 Helidon Integrations documentation Neo4J Jul 22, 2022
tjquinno
tjquinno requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, some more urgent changes requested.

docs/config/io_helidon_integrations_neo4j.adoc Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
tjquinno
tjquinno requested changes Jul 23, 2022
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor additional edits requested. Apologies for not realizing the config .adoc file was not generated automatically.

docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Show resolved Hide resolved
docs/mp/integrations/neo4j.adoc Outdated Show resolved Hide resolved
tjquinno
tjquinno previously approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enduring my comments!

@dalexandrov dalexandrov marked this pull request as ready for review July 24, 2022 07:17
@dalexandrov dalexandrov merged commit a59e059 into helidon-io:master Jul 25, 2022
@dalexandrov dalexandrov deleted the 4299_Doc_Helidon_MP_Integrations_documentation_Neo4J branch July 25, 2022 12:17
ljamen
ljamen reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, small edits.

docs/mp/integrations/neo4j.adoc Show resolved Hide resolved
docs/se/integrations/neo4j.adoc Show resolved Hide resolved
docs/se/integrations/neo4j.adoc Show resolved Hide resolved
docs/se/integrations/neo4j.adoc Show resolved Hide resolved
This was referenced Jul 27, 2022
Closed
Closed
@dalexandrov dalexandrov moved this from Backlog to In progress in Helidon Doc Jul 28, 2022
@dalexandrov dalexandrov mentioned this pull request Jul 29, 2022
Closed
@ljamen ljamen moved this from In progress to Done in Helidon Doc Aug 2, 2022
@ljamen ljamen moved this from Done to In progress in Helidon Doc Aug 2, 2022
@ljamen ljamen moved this from In progress to Done in Helidon Doc Aug 10, 2022
@ljamen ljamen modified the milestones: 3.0.0, 3.0.1 Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljamen ljamen ljamen left review comments

@m0mus m0mus m0mus approved these changes

@tjquinno tjquinno tjquinno left review comments

@arjav-desai arjav-desai Awaiting requested review from arjav-desai

Assignees

@dalexandrov dalexandrov

Labels
completed_language_review docs integration
Projects
Helidon Doc
  
Done
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

[Doc:] Helidon MP Integrations documentation
4 participants
@dalexandrov @m0mus @tjquinno @ljamen