Upgrade protobuf to support osx-aarch_64 architecture #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort osx-aarch_64) Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added
grpc
dependencies
|
I confirm all builds on: |
ljnelson
requested changes
Jul 29, 2022
ljnelson
previously approved these changes
Jul 29, 2022
barchetta
previously approved these changes
Jul 29, 2022
ljnelson
approved these changes
Aug 2, 2022
tomas-langer
added a commit
to tomas-langer/helidon
that referenced
this pull request
Aug 2, 2022
* Version manage protoc to align with Google protobuf version (and support osx-aarch_64) * Upgrade protobuf version Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added a commit
that referenced
this pull request
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use version defined by a property instead of a hardcoded one.
Resolves #4482 for 2.x
Once this is merged, I will create an update for 3.x branch as well
@dalexandrov @ljnelson could you please verify on the architecture this really fixes the problem? Thanks!